Skip to content

Conversation

@mxsm
Copy link
Owner

@mxsm mxsm commented Dec 27, 2025

Which Issue(s) This PR Fixes(Closes)

Fixes #5040

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

  • Chores
    • Updated dependencies to use pinned commit versions.

✏️ Tip: You can customize this high-level summary in your review settings.

@rocketmq-rust-bot
Copy link
Collaborator

🔊@mxsm 🚀Thanks for your contribution🎉!

💡CodeRabbit(AI) will review your code first🔥!

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 27, 2025

Walkthrough

The pull request updates two git-pinned dependencies in the controller's Cargo.toml from floating branches to specific commit revisions: raft from "master" branch to revision "1fd05e0" and openraft from "release-0.10" branch to revision "534bf40", ensuring reproducible builds with locked dependency versions.

Changes

Cohort / File(s) Summary
Dependency Version Pinning
rocketmq-controller/Cargo.toml
Updated raft git dependency from branch "master" to pinned revision "1fd05e0"; updated openraft git dependency from branch "release-0.10" to pinned revision "534bf40"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

enhancement✨

Suggested reviewers

  • SpaceXCN
  • TeslaRustor
  • rocketmq-rust-bot

Poem

🐰 Bouncing through the branches bright,
We pin commits so versions right,
No floating refs to cause a fright—
Locked and steady, oh what delight!
The cargo builds now, solid and tight! 📦✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating raft and openraft dependencies to specific commit revisions in Cargo.toml.
Linked Issues check ✅ Passed The pull request implements the stated objective from issue #5040 by updating raft and openraft dependencies to specific commit revisions.
Out of Scope Changes check ✅ Passed All changes in the pull request are directly related to updating dependency pins in Cargo.toml, which aligns with the linked issue #5040 requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch enh-5040

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20c9533 and 017c10d.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • rocketmq-controller/Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: auto-approve
🔇 Additional comments (2)
rocketmq-controller/Cargo.toml (2)

30-30: Good practice to pin to a specific commit.

Pinning the raft dependency to a specific commit revision (1fd05e0) improves build reproducibility and stability. The commit exists and is reachable on the master branch of tikv/raft-rs.


33-33: Pinning to a specific commit is good practice for build reproducibility.

The commit 534bf40d9acd02d2405e1786323a54520418e7cc exists in the databendlabs/openraft repository and is related to deprecation of TokioRuntime and TokioInstant re-exports. Locking the dependency to this specific revision ensures consistent, reproducible builds.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement✨] Update raft and openraft dependencies to specific commit revisions in Cargo.toml

4 participants