Open
Conversation
Fabolo12
approved these changes
Feb 12, 2025
Comment on lines
+209
to
+211
| try { | ||
| future.get(); | ||
| } catch (InterruptedException | ExecutionException e) { |
There was a problem hiding this comment.
Не оптимальний спосіб очікування, тому що блокується потік
Comment on lines
+119
to
+120
| // Чекаємо на завершення всіх задач | ||
| waitForAllFutures(futures); |
There was a problem hiding this comment.
Взагалі, якщо результат, що повертається, не важливий, то використовувати Future для маркера завершеності це занадто ускладнювати систему
Comment on lines
+164
to
+177
| synchronized (this){ | ||
| ateThisTick++; | ||
| } | ||
| if (animal instanceof Predator){ | ||
| synchronized (this){ | ||
| eatenThisTick++; | ||
| } | ||
| } | ||
| } | ||
| if (animal.multiply()){ | ||
| synchronized (this){ | ||
| bornThisTick++; | ||
| } | ||
| } |
There was a problem hiding this comment.
Краще зробити один великий блок синхронізації
| spawnPlants(Plant.class); | ||
| } | ||
|
|
||
| private <T extends Animal> void spawnAnimals(Class<T> animalClass) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.