split sampleImage and video #2001
Merged
+88
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walesch-yan
commented
Dec 19, 2025
walesch-yan
commented
Dec 19, 2025
walesch-yan
commented
Dec 19, 2025
walesch-yan
commented
Dec 19, 2025
walesch-yan
commented
Dec 19, 2025
axelboc
reviewed
Dec 19, 2025
Collaborator
axelboc
left a comment
axelboc
left a comment
There was a problem hiding this comment.
Love it! A great step for cleaning up SampleView. I just a few touch-ups to suggest.
walesch-yan
force-pushed
the
yw-split-SampleImage-and-video
branch
from
ea024b0 to
7f9542d
Compare
Collaborator
Author
|
@axelboc, thanks for the overall suggestions. I applied them to this newer version |
Member
|
Awesome, thanks ! |
marcus-oscarsson
force-pushed
the
yw-split-SampleImage-and-video
branch
from
7f9542d to
ed1d063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends a first refactoring of the
SampleImagecomponent, by extracting the video stream logic and putting it into its own functional component (VideoPlayer). This component handles the creation and management of the main stream.See comments below for details on changes.