Simplify interleaved data collection availability logic in queue UI #1999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
commented
Dec 18, 2025
| </div> | ||
| <Collapse | ||
| id={`collapse-${data.queueID}`} | ||
| in={Boolean(displayData.collapsed)} |
Collaborator
Author
There was a problem hiding this comment.
Removing this Boolean type cast now that it's guaranteed to remain a boolean in the state.
| } | ||
| case 'COLLAPSE_ITEM': { | ||
| const displayData = { ...state.displayData }; | ||
| displayData[action.queueID].collapsed ^= 1; // eslint-disable-line no-bitwise |
Collaborator
Author
There was a problem hiding this comment.
In addition to turning the collapsed state into a number, this line also mutates the Redux state, which is not recommended.
walesch-yan
approved these changes
Dec 18, 2025
Member
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CurrentTreerelated to creating interleaved data collectionsqueueGUIreducer to avoid ending up with0/1values in thedisplayData.collapsed/selectedstate instead of booleans.