Add TransparentHandlerWithOptions function#73
Open
hashi-derek wants to merge 2 commits intomwitkow:masterfrom
Open
Add TransparentHandlerWithOptions function#73hashi-derek wants to merge 2 commits intomwitkow:masterfrom
hashi-derek wants to merge 2 commits intomwitkow:masterfrom
Conversation
Prior to this function being added, it was not possible to set gRPC CallOptions on the call to `grpc.NewClientStream(...)` performed by the TransparentHandler. Notably, the `grpc.MaxRecvMsgSize()` would not be configured and would result in closed streams if the payload size was exceeded, despite the fact that the proxy's server had the value correctly configured. The introduction of this `TransparentHandlerWithOptions(...)` function allows for various settings to be configured on the handler and passed through to the `grpc.NewClientStream(...)` call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this function being added, it was not possible to set gRPC CallOptions on the call to
grpc.NewClientStream(...)performed by the TransparentHandler.Notably, the
grpc.MaxRecvMsgSize()would not be configured and would result in errors if the payload size was exceeded, despite the fact that the proxy's server had the value correctly configured.The introduction of this
TransparentHandlerWithOptions(...)function allows for various settings to be configured on the handler and passed through to thegrpc.NewClientStream(...)call.