Skip to content

Update MassBankEU URL & Checkout submodules for Unit Tests#218

Merged
mwang87 merged 5 commits intomwang87:devfrom
Michael-C-Strobel:dev
Jan 20, 2026
Merged

Update MassBankEU URL & Checkout submodules for Unit Tests#218
mwang87 merged 5 commits intomwang87:devfrom
Michael-C-Strobel:dev

Conversation

@Michael-C-Strobel
Copy link
Contributor

@Michael-C-Strobel Michael-C-Strobel commented Jan 18, 2026

Fixes #217

  • Update MassBankEU URL to https://massbank.eu/MassBank-api/records/
  • Descriptive stack traces for MONA from MassBankEU errors vs only MONA code paths
  • Update unit test to pull submodules and install umami.

Unit tests are still not running do to the deprecation of imghdr from the standard library but this should probably be a separate PR.

@Michael-C-Strobel
Copy link
Contributor Author

Now also fixes #216

@mwang87 mwang87 merged commit 6b42c60 into mwang87:dev Jan 20, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Massbank Riken spectrum fails to resolve

2 participants