asterisk globbing inside the source Docker image and additional fixes#3
Open
burdandrei wants to merge 5 commits intomvanholsteijn:masterfrom
Open
asterisk globbing inside the source Docker image and additional fixes#3burdandrei wants to merge 5 commits intomvanholsteijn:masterfrom
burdandrei wants to merge 5 commits intomvanholsteijn:masterfrom
Conversation
Clean up container by --rm
Owner
|
Hi @burdandrei, I had missed all pull requests and am currently merging them. It appears that you are still working on your branch so I see more changes that the original one. Can you check which changes you will want to merge? |
Identation using spaces
Author
|
hi @mvanholsteijn, i rebased my commits to the things you merged, please see if it fits you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main fix here is
Fix: asterisk globbing inside the source Docker imagecause if you pass-f '/lib/*/libnss*'the globing was made on the host system, not inside the source container.