fix: support both path and query string formats for unlisted video hash #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liby is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
PR muxinc#195 changed h parameter extraction to only use query string format, breaking support for path format URLs like vimeo.com/123/abc123. This fix supports both: - Path format: vimeo.com/123/abc123 - Query format: vimeo.com/123?h=abc123 Fixes regression from muxinc#195
liby
force-pushed
the
fix/vimeo-unlisted-hash-path-format
branch
from
3ed325a to
f1a9dce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #195 changed
hparameter extraction to only use query string format, breaking support for path format URLs likevimeo.com/123/abc123.This fix supports both:
vimeo.com/123/abc123vimeo.com/123?h=abc123Fixes regression from #195