-
Notifications
You must be signed in to change notification settings - Fork 40
feat: Add played ranges tracking to iframe based media elements #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add played ranges tracking to iframe based media elements #199
Conversation
|
@ronalduQualabs is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
This looks good. There is an indenting and line space issue. I think it would be good to make this a mixin utility like @heff pointed out so it could be used for other iframe video elements. Something like let MyMixin = (superclass) => class extends superclass {
foo() {
console.log('foo from MyMixin');
}
};You might have to override the dispatchEvent method to execute code before the events are fired. |
|
@luwes It's ok if we close this one then in another issue migrate this logic into a mixin ? |
| addPlayedRange(start: number, end: number): void; | ||
| readonly played: TimeRanges; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should also add (onPlaybackStart, onSeeking, onSeeked, etc)
This PR resolves 12 also resolves 205 adds tracking of played ranges to the iframe based media elements. Played time ranges are merged if they overlap, and seeking is properly taken into account, providing an accurate representation of which parts of the video have been played.
Add this ability to:
Youtube
Vimeo
Twitch
TikTok
Spotify Audio