Issue: Every time the app starts the fbvalue is reset to the defaul va…#6
Open
monishsyed wants to merge 1 commit intomutualmobile:masterfrom
Open
Conversation
…lue. Cause: Creating a new instance of FBTweak and setting the current value to nil resets the UserDefaults value. FBTweak gets instantiated with an identifier which is therefore used as a key to get the value for UserDefaulst store so there is no need to set the current value to nil when instantiating a new FBTweak
Contributor
|
@monishsyed that change looks good to me, and works when I tested it out locally. After leaving MM, I no longer have write access to accept pull requests to this repo though, so you may need to check with someone there to get it merged. Also, I don't have access to view the reason for the travis failure. It may just be that the config needs to be updated to a newer version of Xcode? Are you able to see why the automated check reported a failure? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lue.
Cause: Creating a new instance of FBTweak and setting the current value to nil resets the UserDefaults value. FBTweak gets instantiated with an identifier which is therefore used as a key to get the value for UserDefaulst store so there is no need to set the current value to nil when instantiating a new FBTweak