Update docs to reflect Meridian integration #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjmccorm1993
commented
Jul 9, 2025
| fit() is called, which is critical for the validation suite to work correctly. | ||
| Only attributes that are set during fit() should be reset here. | ||
| """ | ||
| # Explicitly delete trace to free TensorFlow memory |
Contributor
Author
There was a problem hiding this comment.
@joekang1 @benjamin-dobrin running the tests with Meridian, even on a small dataset with low samples, eats up memory really quickly. I'm guessing this is a problem on their side, but added this as an attempt to clean up after running fit() each time
Collaborator
There was a problem hiding this comment.
interesting, yeah i'm not sure at face value. fingers crossed this isn't a blocker to our model comparisons on actual data
joekang1
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've deployed the latest updates so you should also be able to see them here: https://miniature-succotash-mrjk8q5.pages.github.io/