Adding option to specify agent bundle location via env var#537
Open
bfosberry wants to merge 1 commit intomutagen-io:masterfrom
Open
Adding option to specify agent bundle location via env var#537bfosberry wants to merge 1 commit intomutagen-io:masterfrom
bfosberry wants to merge 1 commit intomutagen-io:masterfrom
Conversation
This change allows the mutagen agent bundle code to add agent search locations via an additional env var. If the agent tar is in a different directory than the binary then this can be used to point to the location of the tar.gz file
bfosberry
force-pushed
the
allow-path-override
branch
from
f2e9da2 to
67e38e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do and why is it needed?
This change allows the mutagen agent bundle code to add agent search locations via an additional env var. If the agent tar is in a different directory than the binary then this can be used to point to the location of the tar.gz file
This does include populating search paths form env in all cases, however it should be a lightweight change, and will only take action if there is a value set. If there is an issue verifying that the folder exists, the following behaviour will not be changed. Worst case, if a value is specified unintentionally, then the modified behaviour will mean we look in one additional folder when trying to find the agents file.