Open
Conversation
Author
|
Sorry for the multiple force-pushes. This was the first time I had to create a signed commit and it took a few tries to get it all working. |
allanmfx
approved these changes
Aug 13, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces all
err==w/errors.Is()in this repo's codebase — as recommended for Go 1.13+ — with more details at #504.Also, I omitted
haveShortLastBlockas using it caused lint to flag otherwise correct use ofshortLastBlockas potentially beingnil. I just usedshortLastBlock!=nilinstead which made my linter happy.I understand you may not want to accept these changes, and if so, I respect that. This less fragile error handling can be infinitesimally slower, and/or you may prefer not to remove
haveShortLastBlock.I made these changes for my own to make it easier to work on my fork for #505. I would be very happy if you allow me to give these back to the community, but if you dislike them I will just maintain my fork as long as #505 is not accepted and/or my use-case for #505 is not otherwise resolved, and as long as I am using Mutagen to update Docker volumes on a remote machine.