Put all the wallpapers in their own sub-directory #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To install the wallpapers as a package, and mostly to avoid missing any wallpaper during the building of the package, it is much easier to place all the wallpapers under the same location, allowing to run `cp -rf wallpapers/*` inside the PKGBUILD.
Now that the images are not inside the root anymore, the preview generation script should pick the right filenames.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR a refactor of #5 which was not presented in the right way... I hope this PR will be clearer and less of a mess 😋
My first idea was to be able to install your wallpapers on my Arch based system, 'cause i like them a lot!
However, as all the images are in the root of the repo, alongside the
READMEand other non-wallpaper files, and as they do not all have the same image extensions, i found that quite tideous and error prone to move all of them during the build time in the PKGBUILD.This PR simply moves all the wallpapers to the new
./wallpaperssub-directory, changes the path to the files in the preview generation and generates the newREADME.Hope you'll find that usefull or a bit cleaner @mut-ex 😉
and sorry again for the other very awful PR... 😓