Skip to content

fixed EditMidiMappingModel destruction #32760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
igorkorsukov wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

fixed EditMidiMappingModel destruction #32760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/framework/shortcuts/qml/Muse/Shortcuts/editmidimappingmodel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ EditMidiMappingModel::EditMidiMappingModel(QObject* parent)

EditMidiMappingModel::~EditMidiMappingModel()
{
midiRemote()->setIsSettingMode(false);
if (m_loaded) {
midiRemote()->setIsSettingMode(false);
}
}

void EditMidiMappingModel::load(int originType, int originValue)
Expand All @@ -50,6 +52,8 @@ void EditMidiMappingModel::load(int originType, int originValue)

m_event = RemoteEvent(static_cast<RemoteEventType>(originType), originValue);
emit mappingTitleChanged(mappingTitle());

m_loaded = true;
}

QString EditMidiMappingModel::mappingTitle() const
Expand Down
1 change: 1 addition & 0 deletions src/framework/shortcuts/qml/Muse/Shortcuts/editmidimappingmodel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ class EditMidiMappingModel : public QObject, public Contextable, public async::A
private:
QString deviceName(const muse::midi::MidiDeviceID& deviceId) const;

bool m_loaded = false;
RemoteEvent m_event;
};
}
Loading