Skip to content

Fix stale item selection UI after clearing selection#32657

Open
CubikingChill wants to merge 1 commit intomusescore:masterfrom
CubikingChill:fix/selectable-item-clear-selection-ui-sync
Open

Fix stale item selection UI after clearing selection#32657
CubikingChill wants to merge 1 commit intomusescore:masterfrom
CubikingChill:fix/selectable-item-clear-selection-ui-sync

Conversation

@CubikingChill
Copy link
Contributor

Resolves: #32645

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

{
m_selection->clearSelection();

if (rowCount() > 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix this the same way it's done here:

Image

This way, we won't have to add dataChanged to every function that modifies the selection

@CubikingChill CubikingChill force-pushed the fix/selectable-item-clear-selection-ui-sync branch from e62e64f to e6b4760 Compare March 24, 2026 12:37
@CubikingChill CubikingChill force-pushed the fix/selectable-item-clear-selection-ui-sync branch from e6b4760 to 57fb465 Compare March 24, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SelectableItemListModel::clearSelection() does not notify views that isSelected changed

2 participants