Stave labelling improvements#32605
Merged
mike-spa merged 5 commits intomusescore:masterfrom Mar 24, 2026
Merged
Conversation
mike-spa
force-pushed
the
staveLabellingImprovements
branch
6 times, most recently
from
244f278 to
73da0dc
Compare
miiizen
reviewed
Mar 24, 2026
src/engraving/dom/instrumentname.h
Outdated
|
|
||
| staff_idx_t effectiveStaffIdx() const override; | ||
|
|
||
| staff_idx_t endIdxOfGroup() const { return m_endIdxOfGroup; } |
Contributor
There was a problem hiding this comment.
This could also be in ldata
|
|
||
| const String& transp = i->transposition(); | ||
| if (!transp.empty()) { | ||
| fullName += u" " + muse::mtrc("notation", "in") + u" " + transp; |
Contributor
There was a problem hiding this comment.
Perhaps leave some context for translators with a //: comment above, saying that this is for instrument transpositions
src/engraving/dom/system.cpp
Outdated
| sysStaff->individualStaffName = nullptr; | ||
| } | ||
| toInstrumentName(el)->setSysStaff(0); | ||
| n->setSysStaff(0); |
Contributor
There was a problem hiding this comment.
Nitpick while we're here: I prefer nullptr
src/engraving/dom/system.cpp
Outdated
| return result; | ||
| } | ||
|
|
||
| std::vector<mu::engraving::Part*> mu::engraving::System::visiblePartsOfGroup(staff_idx_t start, staff_idx_t end) const |
Contributor
There was a problem hiding this comment.
Suggested change
| std::vector<mu::engraving::Part*> mu::engraving::System::visiblePartsOfGroup(staff_idx_t start, staff_idx_t end) const | |
| std::vector<Part*> System::visiblePartsOfGroup(staff_idx_t start, staff_idx_t end) const |
| InstrumentNamesFormat nameFormat | ||
| = style.styleV(longNames ? Sid::instrumentNamesFormatLong : Sid::instrumentNamesFormatShort).value<InstrumentNamesFormat>(); | ||
|
|
||
| String in = TranslatableString("notation", "in").translated(); |
Contributor
There was a problem hiding this comment.
Some //: context here and in formattedGroupName could be useful too
mike-spa
force-pushed
the
staveLabellingImprovements
branch
from
73da0dc to
7e0c231
Compare
mike-spa
force-pushed
the
staveLabellingImprovements
branch
from
7e0c231 to
5a7a437
Compare
miiizen
approved these changes
Mar 24, 2026
mike-spa
force-pushed
the
staveLabellingImprovements
branch
from
5a7a437 to
95a63a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.