Add support for T/t and P/p in fretboard fingerings (Fixes #23755)#31428
Open
pyonpyoco wants to merge 3 commits intomusescore:masterfrom
Open
Add support for T/t and P/p in fretboard fingerings (Fixes #23755)#31428pyonpyoco wants to merge 3 commits intomusescore:masterfrom
pyonpyoco wants to merge 3 commits intomusescore:masterfrom
Conversation
ba87f29 to
025ee51
Compare
|
@pyonpyoco Thanks for working on this. Would you mind rebasing so I can test this? As to mapping the letters to 6 and 7 in older versions, I think it would be better if we just wiped the field clear if they contained T/t/P/p. 6 and 7 don't map to any fingers after all, so it would be better to erase the marking entirely. |
025ee51 to
faa637d
Compare
Contributor
Author
|
@avvvvve Thanks, I’ve rebased onto the latest master so you can test it. I’ll take another look at the backward-compatibility behavior you suggested. Just to confirm: do you mean clearing only the unsupported T/t/P/p fingering entries for backward compatibility, while keeping valid numeric fingerings unchanged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #23755
Description:
This PR adds support for entering T/t (thumb) and P/p (pulgar) as fingering values for fretboard diagrams.
Changes:
Backward compatibility:
Opening scores using this feature in older versions (4.6.3) of MuseScore currently displays the digits 6 and 7.
Please advise if backward compatibility handling or a conversion layer is preferred.
UI example