Do not use persistent status sections for status messages#5
Open
kaste wants to merge 2 commits intomunkybutt:masterfrom
Open
Do not use persistent status sections for status messages#5kaste wants to merge 2 commits intomunkybutt:masterfrom
kaste wants to merge 2 commits intomunkybutt:masterfrom
Conversation
Initially the plugin used `window.status_message`s which disappear after a few seconds. A persistent message like "sublack: reformatted" which doesn't even go away when editing the file is not helpful. Persistent messages for the daemon *on the view* are also a mistake as they stick to the view although the daemon has been probably started for the window. Make them non-sticky as well.
Author
|
CI pipeline is broken; the startup code doesn't even run. |
Author
|
Sorry for that, you're not the maintainer of sublack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially the plugin used
window.status_messages which disappearafter a few seconds. A persistent message like "sublack: reformatted"
which doesn't even go away when editing the file is not helpful.
Persistent messages for the daemon on the view are also a mistake
as they stick to the view although the daemon has been probably started
for the window. Make them non-sticky as well.