Readme changes including the change requested in issue #4 "Need to change image name from redsocks to munkyboy/redsocks in docker run command" #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed image name from just redsocks to munkyboy/redsocks, so it will be better found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi munkyboy,
here again: a PR for cherry-picking. However, it might not be easy to find the right commit in this mess.
😊
The minimum I see is to change the docker run command from "redsocks" to "munkyboy/redsocks". This is done in the first commit, but I had added the
-e https_proxy ...at the same time, and thedocker runcommand got a little bit too long for my taste. It is also O.K., if you just change "redsocks" to "munkyboy/redsocks", I guess.Thanks,
Oliver