-
Notifications
You must be signed in to change notification settings - Fork 83
Update Packages #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Update Packages #437
Conversation
radumojic
commented
Dec 30, 2025
- update packages
- removed unused components
Summary of ChangesHello @radumojic, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining the project's health and efficiency by updating its core dependencies and removing an identified unused component. These changes aim to keep the application current with the latest library versions, improve stability, and reduce the overall bundle size by eliminating dead code. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates various dependencies and removes an unused component import. The dependency updates are mostly straightforward version bumps. I've added a couple of comments regarding a package downgrade and a newly introduced deprecated package that might need attention to ensure long-term maintainability and security.
| '@stencil/core@4.38.1': | ||
| resolution: {integrity: sha512-qImplYLSp2wSZJo3oMZ3HrTaI+uULcRB4Knrua7UT9VjN/va+TDfk4JAKwDyDfTDkD2laDPcy6QJP2S3hVxZFQ==} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that @stencil/core is being downgraded from 4.38.3 to 4.38.1 as a result of updating @multiversx/sdk-dapp-ui. While this might be intentional, downgrading a package can potentially reintroduce bugs or security issues. It would be beneficial to document the reason for this specific version constraint to aid future dependency management.
| whatwg-encoding@2.0.0: | ||
| resolution: {integrity: sha512-p41ogyeMUrw3jWclHWTQg1k05DSVXPLcVxRTYsXUk+ZooOCZLcoYgPZ/HL/D/N+uQPOtcp1me1WhBEaX02mhWg==} | ||
| engines: {node: '>=12'} | ||
| deprecated: Use @exodus/bytes instead for a more spec-conformant and faster implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package whatwg-encoding@2.0.0 is now marked as deprecated, with the suggestion to use @exodus/bytes instead. This is a transitive dependency introduced via jest-environment-jsdom. Relying on deprecated packages can pose future maintenance and security risks. It would be beneficial to investigate updating the dependency chain to remove this deprecated package.