Skip to content

added state to unbind toggleMap from being bound to F2 #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MittellBuurman wants to merge 4 commits into from
Closed

added state to unbind toggleMap from being bound to F2 #570

MittellBuurman wants to merge 4 commits into from

Conversation

@MittellBuurman
Copy link
Contributor

@MittellBuurman MittellBuurman commented Oct 29, 2024

Fixes #535

  • Added a check to see if the race recource is running when freeroam is running. Disabling/unbinding the toggleMap feature from the client (since you're racing, and likely testing the map, having a map spawn selector doesn't seem useful here).

@jlillis jlillis added this to the Next Release (1.6.1) milestone Nov 5, 2024
Dutchman101 and others added 3 commits November 11, 2024 12:56
@MittellBuurman
Add 'superman' to official resources
448b9d2 
Resource originally written and published by MTA team member Ryden (Alberto Alonso). I've made several tweaks to it over time, while it ran on a large freeroam server.
@sacr1ficez @MittellBuurman
superman: Initial fixes (multitheftauto#572)
3502c19 
* Initial fixes for superman

* Update meta.xml

* Fix lint warnings.
@MittellBuurman
Fix multitheftauto#535: Map key bind interferes with race editor help
466ec1b 
Added onClientResourceStart and onClientResourceStop event handlers to
listen on the root element.

When both the editor resource, and the race resource are active, it
unbinds toggleMap from F2

When the editor resource is active, and you stop the race resource, it
binds toggleMap back to F2.

Since the help menu in Race is only active when the editor is active,
this should really be the only time it should either bind or unbind the
toggleMap.
@MittellBuurman
Copy link
Contributor Author

MittellBuurman commented Nov 11, 2024

Closed PR due to author commit conflicts

@MittellBuurman MittellBuurman deleted the bugfix-535 branch November 11, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement resource:freeroam

Projects

None yet

Milestone

Next Release (1.6.1)

Development

Successfully merging this pull request may close these issues.

freeroam: Map key bind interferes with race editor help

4 participants

@MittellBuurman @jlillis @Dutchman101 @sacr1ficez