Enhance list-backed action discovery for mouse gesture picker#929
Merged
multiplex55 merged 2 commits intomasterfrom Mar 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
query:stubs.Description
list_query_prefix_for_plugin()to return(primary_prefix, Option<alternate_prefix>)and add mappings forclipboard,emoji,processes,note/notes,folders,bookmarks,todo, andsnippets.has_concrete_actions()that detects non-query:(concrete) actions.resolve_action_source()to: try the mappedplugin.search()using the primary prefix (with the provided filter), accept results only if they contain concrete actions, retry an alternate prefix if present, and finally fall back toplugin.commands().mouse_gestures_dialog.rstest module by replacing the simple mock with a query-aware mock that records seen queries and supports per-query responses, and add table-driven tests covering each mapped plugin, the alternate-prefix retry, empty-search fallback, and unmapped-plugin fallback.cargo fmtto the modified filesrc/gui/mouse_gestures_dialog.rs.Testing
cargo fmton the modified file which completed successfully.cargo testtargeting the modified test area but full test compilation failed in this environment because the system ALSA development library is missing (pkg-configcould not findalsa.pc), so the added tests could not be executed here.src/gui/mouse_gestures_dialog.rsand validated locally where system dependencies are available.Codex Task