Add hide/show details toggle to NotePanel metadata#897
Merged
multiplex55 merged 3 commits intomasterfrom Feb 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
show_metadata: booltoNotePaneland initialized it totrueinNotePanel::from_noteso panels default to showing metadata.details_toggle_label()helper and a top-row toggle button (rendersHide Details/Show Details) placed before the font-size controls; toggling reuses the existingfocus_textedit_next_framepattern to preserve keyboard focus behavior.uiwithif self.show_metadata { ... }guards; the editor/preview content area remains always visible and backlink tabs/pagination state are preserved when hiding/showing.#[cfg(test)]module:toggle_hides_metadata_sections_in_ui,toggle_button_label_reflects_state, andtoggle_preserves_tab_and_pagination_state, and a small helperrender_panel_and_dump_shapesto exercise UI rendering in tests.Testing
cargo fmt -- src/gui/note_panel.rssuccessfully to format the changes.cargo test toggle_button_label_reflects_state), but the test build failed in this environment due to a missing system dependency required by a transitive crate (alsa-sysrequires a systemalsapkg-config file), preventing completion ofcargo testruns here.Codex Task