Refactor save_note to use cache-driven slug collision handling and add tests#889
Merged
multiplex55 merged 1 commit intomasterfrom Feb 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
load_notes()call that was used only for slug awareness and rely on the in-memory cache for slug collision context.unique_slugfrom known cached slugs while excluding the current note’s path/slug.refresh_cache()and add regression tests for common edge cases.Description
load_notes()with anexisting_slugsset derived fromCACHE.lock()?.notesthat filters out the current note by path/slug.reset_slug_lookup()andregister_slug()for cached slugs and then usingunique_slug()whennote.slugis empty.if existing_slugs.contains(&slug) && note.path != path && !overwrite { return Ok(false); }) while keepingrefresh_cache()as the single refresh after write.save_existing_note_succeeds_without_overwrite,save_as_new_generates_unique_slug_from_cache, andsave_note_renames_slug_and_pathto cover overwrite, save-as-new slug generation, and rename behavior.Testing
cargo fmt --allwhich succeeded.cargo test save_note_, but the build aborted due to a missing system dependency required by a transitive crate (alsa/alsa.pc), so the test run could not complete in this environment.src/plugins/note.rsand should pass in an environment with required system libraries installed.Codex Task