Cache todo links index by todo/note version signals#887
Merged
multiplex55 merged 1 commit intomasterfrom Feb 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
todo linksquery by caching the computed(notes, index)when source data hasn't changed.Description
TodoLinksIndexCacheand a process-wideTODO_LINKS_INDEX_CACHEkeyed by(todo_version(), note_version())to storenotesand theLinkIndexinsrc/plugins/todo.rs.get_todo_links_index()which returns a cached(notes, index)when versions match and otherwise rebuilds the index and updates the cache while incrementingTODO_LINKS_INDEX_REBUILD_COUNT.invalidate_todo_links_index_cache()fromupdate_cache()and the file-watcher closure so watcher-triggered updates also clear the cache.todo linksquery path with a call toget_todo_links_index()and added a unit testtodo_links_reuses_cached_index_between_queriesthat asserts rebuild count behavior.Testing
cargo fmt -- src/plugins/todo.rswhich completed successfully.todo_links_reuses_cached_index_between_queriesexercising cache reuse and invalidation behavior and confirmed it is present in the test suite.todo_links_reuses_cached_index_between_queries), butcargo testfailed in this environment due to a missing system dependency required byalsa-sys(missingalsa.pc), so the test could not be executed here.Codex Task