Cache lowercase aliases for action/plugin matching#885
Merged
multiplex55 merged 1 commit intomasterfrom Feb 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
to_lowercase()calls by caching lowercase alias strings for folders and bookmarks.Description
folder_aliases_lcandbookmark_aliases_lctoLauncherAppand helper buildersfolder_alias_maps()/bookmark_alias_maps()to load both original and pre-lowercased alias values in one pass.normalize_alias()andalias_matches_lc()helpers to centralize alias normalization and case-insensitive matching logic used by search paths.new()to populate both alias maps and updatedprocess_watch_events()to refresh both maps onWatchEvent::FoldersandWatchEvent::Bookmarks, callingsearch()after refresh to update visible results.search_actions()andsearch_plugins()to use the cached lowercase alias maps viaalias_matches_lc()instead of callingto_lowercase()inside tight loops, while continuing to use the existingaction_cachefor lowercase label/desc checks.src/gui/mod.rs.)Testing
cargo fmt --allwhich completed successfully.cargo testfor the added unit(s), but the build failed in this environment during dependency compilation due to a missing system library required byalsa-sys(pkg-config/alsa.pcnot available), so the new tests could not be executed here.cargo fmtapplied; the search behavior and alias-refresh logic are covered by the new unit tests for environments where system build deps are present.Codex Task