Auto-label gestures from recordings and generalize plugin list expansion in binding picker#824
Merged
multiplex55 merged 2 commits intomasterfrom Feb 12, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
is_default_generated_label,normalize_recorded_tokens_for_label, andlabel_from_recorded_tokensto sanitize, truncate, and format auto-generated labels asGesture <TOKENS>.MgGesturesDialog::apply_recording_to_entryso both theUse Recordingbutton and drag-completion path settokens,stroke,token_bufferconsistently and auto-update the label only whenis_default_generated_labelreturns true.list_query_prefix_for_pluginand a resolverresolve_action_sourcethat callsplugin.search(<list-prefix + filter>)for mapped plugins and falls back toplugin.commands()when needed.apply_action_pickandappend_query_argsto reliably setBindingKind,action, andargsforquery:-prefixed actions,launcher:toggle, and regular execute actions, including safe concatenation of extra args.resolve_action_sourceandapply_action_pickso selected list entries write correctBindingKind,action, andargsfields.mod testscoveringauto_label_is_applied_only_for_default_generated_labels,customized_label_is_preserved_when_new_recording_is_applied, andresolve_action_source_prefers_mapped_list_search_and_falls_back_to_commands.Testing
cargo fmtsuccessfully to format changes.cargo test mouse_gestures_dialog -- --nocapture, but tests could not run in this environment due to the workspace resolving dependencies that requirerustc 1.88.0while the available toolchain isrustc 1.87.0; tests were added but not executed here because of that toolchain mismatch.Codex Task