Normalize static window settings when follow-mouse mode is active#823
Merged
multiplex55 merged 1 commit intomasterfrom Feb 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
follow_mouseand static window settings by ensuring static mode is disabled when follow mode is active.follow_mouseis enabled to prevent surprising UI behavior and accidental persistence of conflicting geometry.Description
SettingsEditor::normalized_static_settingsandnormalize_static_window_configinguito centralize the rule thatfollow_mouse == true=> static mode is disabled and static geometry cleared.src/settings_editor.rsinitialized editor state vianormalized_static_settings, madeto_settingsreturn normalized values (clearingstatic_pos/static_sizewhen follow is enabled), and updated the settings UI so togglingFollow mouseimmediately setsstatic_enabled = falseand static geometry controls are not rendered while follow mode is active.src/gui/mod.rsapplied normalization during app initialization and in theupdate_paths/apply flow so loaded or applied settings cannot reintroduce conflicting static configuration.to_settings_disables_static_when_follow_mouse_enabledinsrc/settings_editor.rsandlauncher_new_normalizes_conflicting_follow_mouse_static_configinsrc/gui/mod.rsto cover saving and loading normalization cases.Testing
cargo fmtsuccessfully to format the modified files.to_settings_disables_static_when_follow_mouse_enabledandlauncher_new_normalizes_conflicting_follow_mouse_static_config, but runningcargo testin this environment failed due to a toolchain mismatch (installedrustc 1.87.0while a dependency requiresrustc 1.88.0), so the new tests were not executed here.cargo testinvocation, but the test code is present and will run successfully in a compatible toolchain or CI.Codex Task