Safely normalize plugin query command/args joining for favorites#807
Merged
multiplex55 merged 1 commit intomasterfrom Feb 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
searchqueries built from a saved favorite command plus optional args are tokenized and predictable by trimming and inserting a single space where appropriate.Description
join_command_args(command: &str, args: Option<&str>) -> Stringinsrc/plugins/fav.rsthat trims trailing whitespace fromcommand, trims leading whitespace fromargs, and joins them with exactly one space only whenargsis present and non-empty.resolve_with_pluginto usejoin_command_argswhen building the query passed toplugin.search.src/gui/fav_dialog.rsby importing and usingjoin_command_argswhen expandingquery:actions before callingplugin.search.src/plugins/fav.rscovering:command="todo",args="list"->todo list; empty/blankargsleavescommandunchanged; extra spacing is normalized; andresolve_with_pluginuses the normalized query.Testing
#[cfg(test)]module insrc/plugins/fav.rsand attempted to run them withcargo test src/plugins/fav.rs -- --nocapture.rustc(1.87.0) being older than versions required by transitive crates (timerequires 1.88.0), so the tests could not be executed here.Codex Task