Add action metadata and selected-action preview panel#806
Closed
multiplex55 wants to merge 2 commits intomasterfrom
Closed
Add action metadata and selected-action preview panel#806multiplex55 wants to merge 2 commits intomasterfrom
multiplex55 wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
preview_text: Option<String>,risk_level: Option<ActionRiskLevel>, andicon: Option<String>plus a newActionRiskLevelenum for Low/Medium/High/Critical insrc/actions/mod.rs.src/plugins/system.rs,src/plugins/task_manager.rs,src/plugins/recycle.rs, andsrc/plugins/layout.rsso returnedActions carry preview text, a risk classification, and an icon identifier.src/gui/mod.rs) to render a split view showing the results list and a preview pane when an item is selected andpreview_enabledis true, with compact/expanded behavior controlled bypreview_compact_mode.preview_enabledandpreview_compact_modetoSettingsand wire them into the settings editor so the preview panel can be enabled/disabled and persisted; propagate those settings intoLauncherAppstate.Actionfields (defaulting toNonewhere appropriate) and add new unit tests that assert metadata presence and selection/visibility behavior.Testing
cargo fmtsuccessfully to format the changes.cargo checkand running the test suite, butcargo checkfailed in this environment due to a Rust toolchain mismatch (installed rustc 1.87.0 while a dependency requires 1.88.0), so automated compilation/tests could not complete here.tests/selection.rs,tests/gui_visibility.rs,tests/system_plugin.rs,tests/task_manager_plugin.rs,tests/recycle_plugin.rs,tests/layout_plugin.rs), but their execution was blocked by the toolchain constraint.Codex Task