Optimize TodoWidget filtering and alphabetical sorting allocations#805
Merged
multiplex55 merged 1 commit intomasterfrom Feb 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
to_lowercase()allocations during todo filtering and alphabetical sorting to improve performance on large todo lists.Description
normalized_filter_tags()and thread that slice throughentry_matches_filtersandfilter_entriesinstead of lowercasing per comparison.tags_matchto accept normalized filters and useeq_ignore_ascii_casebefore falling back toto_lowercase().contains(...)to get a fast-path for ASCII-equal matches.sort_entrieswith a decorate-sort-undecorate approach (precompute lowercase keys, sort, then rebuildentries) to avoid repeatedto_lowercase()calls inside the comparator.filters_combine_before_sortingunit test to use the new normalized flow and add a Criterion benchmarkbenches/todo_widget_filtering.rs, plus register the bench inCargo.toml.Testing
cargo fmtwhich completed successfully.cargo test --lib dashboard::widgets::todowhich could not run due to the environment toolchain (rustc 1.87.0) being older than a dependency requirement (timerequiresrustc 1.88.0).cargo bench --bench todo_widget_filtering --no-runwhich was likewise blocked by the same toolchain incompatibility, but a micro-benchmark was added and is runnable once the toolchain is updated.Codex Task