Enforce fixed size for Todo View dialog and add sizing tests#797
Merged
multiplex55 merged 3 commits intomasterfrom Feb 6, 2026
Merged
Enforce fixed size for Todo View dialog and add sizing tests#797multiplex55 merged 3 commits intomasterfrom
multiplex55 merged 3 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
TODO_VIEW_SIZEandTODO_VIEW_LIST_HEIGHTand a small helpertodo_view_layout_sizes()insrc/gui/todo_view_dialog.rsto centralize layout values..resizable(false)and setting.default_size,.min_size, and.max_sizeto the fixedTODO_VIEW_SIZEvalues in theegui::Window::new("View Todos")builder.ui.available_height()driven scroll max height with the deterministicTODO_VIEW_LIST_HEIGHTso theScrollAreais bounded and the window remains fixed.src/gui/mod.rsand add tests: a unit test in the dialog module asserting the constants viatodo_view_layout_sizes()and an integration-style GUI test intests/todo_plugin.rsthat opens the dialog and asserts the rendered window size matches the fixed size.Testing
todo_view_layout_sizes_constantsinsrc/gui/todo_view_dialog.rswhich assertsTODO_VIEW_SIZEandTODO_VIEW_LIST_HEIGHTand their relationship; this test was added but not executed here.todo_view_dialog_has_fixed_sizeintests/todo_plugin.rsthat opens the dialog and asserts the window rect size equals the fixed layout; this test was added but not executed here.Codex Task