Refresh pinned commands when actions change#795
Merged
multiplex55 merged 1 commit intomasterfrom Feb 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
cfg.action_idsby addinglast_action_ids_hashandaction_ids_hash(...), and include that hash inrefresh_cacheso the cache is rebuilt when the pinned list changes.crate::actions::bump_actions_version()afterapp.update_action_cache()in the add/edit branches of the action dialog to surface in-memory changes to the dashboard immediately.src/dashboard/widgets/pinned_commands.rsthat verify (1) changingcfg.action_idsforces a cache refresh and (2) bumpingactions_versioncauses cached actions to be rebuilt, using a minimalDashboardContextandDashboardDataCache::new().Testing
cargo testfor the new tests; the build started but failed due to a missing system dependency required byalsa-sys(pkg-config/alsa.pc), so the test run did not complete.alsadevelopment pkg (or appropriate build flags/environment) is available so the project can compile and run tests successfully.Codex Task