Remove require_button, add debug_logging, default no-match to pass-through, and update tests/UI#775
Merged
multiplex55 merged 1 commit intomasterfrom Jan 31, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
require_buttonfield and provide an opt-in debug logging switch for diagnostics.Description
require_buttonwithdebug_logginginMouseGestureSettingsand default it tofalse(src/plugins/mouse_gestures.rs).debug_logginginto runtime config (MouseGestureRuntime::apply) and adddebug_loggingtoMouseGestureConfigso runtime receives the flag (src/plugins/mouse_gestures.rs,src/mouse_gestures/service.rs).println!-style debug dump by emittingtracing::debug!for produced gesture tokens whenconfig.debug_loggingis enabled (src/mouse_gestures/service.rs).PassThroughClickand add a short explanatory note to the settings UIs (src/plugins/mouse_gestures.rs,src/gui/mouse_gesture_settings_dialog.rs).debug_loggingand document the no-match fallback (src/plugins/mouse_gestures.rs,src/gui/mouse_gesture_settings_dialog.rs).tests/mouse_gestures_plugin.rsto validate settings (serialize/deserialize) with the newdebug_loggingfield and to confirm legacy fields likerequire_buttonare ignored.Testing
mouse_gestures_settings_ignore_legacy_fieldsintests/mouse_gestures_plugin.rsto assert legacy JSON still deserializes and thatdebug_loggingis handled correctly.cargo testlocally or in CI to validate the test suite and runtime behavior.Codex Task