Skip to content

Suppress autocomplete suggestions when dashboard is visible #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
multiplex55 merged 1 commit into from
Jan 8, 2026
Merged

Suppress autocomplete suggestions when dashboard is visible #663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/gui/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,10 @@ impl LauncherApp {
fn update_suggestions(&mut self) {
self.autocomplete_index = 0;
self.suggestions.clear();
if !self.query_autocomplete || self.query.is_empty() {
if !self.query_autocomplete
|| self.query.is_empty()
|| self.should_show_dashboard(self.query.as_str())
{
return;
}
if let Some(ref index) = self.completion_index {
Expand Down Expand Up @@ -1089,6 +1092,8 @@ impl LauncherApp {
trimmed.starts_with("timer list") || trimmed.starts_with("alarm list");
self.last_stopwatch_query = trimmed.starts_with("sw list");
if trimmed.is_empty() {
self.autocomplete_index = 0;
self.suggestions.clear();
let mut res = self.command_cache.clone();
for a in self.actions.iter() {
res.push(Action {
Expand Down Expand Up @@ -2672,6 +2677,7 @@ impl eframe::App for LauncherApp {
}

let trimmed = self.query.trim().to_string();
let use_dashboard = self.should_show_dashboard(trimmed.as_str());
self.maybe_refresh_timer_list();
self.maybe_refresh_stopwatch_list();
if trimmed.eq_ignore_ascii_case("net")
Expand Down Expand Up @@ -2726,7 +2732,7 @@ impl eframe::App for LauncherApp {
self.search();
}

if self.query_autocomplete && !self.suggestions.is_empty() {
if self.query_autocomplete && !use_dashboard && !self.suggestions.is_empty() {
ui.vertical(|ui| {
for s in &self.suggestions {
ui.colored_label(Color32::GRAY, s);
Expand Down Expand Up @@ -2809,8 +2815,11 @@ impl eframe::App for LauncherApp {
}
});

let use_dashboard = self.should_show_dashboard(&trimmed);
if use_dashboard {
if !self.suggestions.is_empty() {
self.autocomplete_index = 0;
self.suggestions.clear();
}
let dash_ctx = DashboardContext {
actions: &self.actions,
actions_by_id: &self.actions_by_id,
Expand Down