Skip to content

Fix confirm-remove dialog close handling #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
multiplex55 merged 1 commit into from
Jan 8, 2026
Merged

Fix confirm-remove dialog close handling #662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/gui/dashboard_editor_dialog.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ impl DashboardEditorDialog {
if let Some(slot) = self.config.slots.get(idx) {
let label = Self::slot_label(slot);
let mut open = true;
let mut should_close = false;
egui::Window::new("Confirm remove")
.collapsible(false)
.resizable(false)
Expand All @@ -237,13 +238,16 @@ impl DashboardEditorDialog {
ui.horizontal(|ui| {
if ui.button("Remove").clicked() {
confirm_remove = Some(idx);
open = false;
should_close = true;
}
if ui.button("Cancel").clicked() {
open = false;
should_close = true;
}
});
});
if should_close {
open = false;
}
if !open {
self.confirm_remove_slot = None;
}
Expand All @@ -255,7 +259,7 @@ impl DashboardEditorDialog {
while idx < self.config.slots.len() {
let original_slot = self.config.slots[idx].clone();
let mut slot = original_slot.clone();
let mut removed = confirm_remove == Some(idx);
let removed = confirm_remove == Some(idx);
let mut edited = false;
let mut swapped = false;
ui.push_id(idx, |ui| {
Expand Down