Skip to content

Add dashboard swap/remove toggles and removal confirmation#661

Merged
multiplex55 merged 1 commit intomasterfrom
codex/add-swap-and-remove-button-options
Jan 8, 2026
Merged

Add dashboard swap/remove toggles and removal confirmation#661
multiplex55 merged 1 commit intomasterfrom
codex/add-swap-and-remove-button-options

Conversation

@multiplex55
Copy link
Copy Markdown
Owner

Motivation

  • Provide UI switches to hide swap and remove controls in the dashboard editor to reduce clutter when not needed.
  • Make slot removal safer by requiring an explicit confirmation before a slot is deleted.
  • Ensure the "Show swap" toggle hides both per-slot swap controls (the Swap button and the Swap with selected button).

Description

  • Added boolean fields show_swap_buttons and show_remove_buttons and a confirm_remove_slot: Option<usize> to DashboardEditorDialog with sensible defaults in Default::default.
  • Added two checkboxes to the top control row: Show swap (bound to show_swap_buttons) and Show remove (bound to show_remove_buttons).
  • Wrapped per-slot header actions so the Remove button is only shown when show_remove_buttons is true and both the Swap and Swap with selected controls are only shown when show_swap_buttons is true.
  • Implemented a non-blocking confirmation dialog using an egui::Window that displays Remove slot '{label}'? (using Self::slot_label(...)) and only marks a slot for removal when the user confirms; actual removal is gated by the confirmation state (confirm_remove_slot / confirm_remove).

Testing

  • No automated tests were executed for this change.

Codex Task

@multiplex55 multiplex55 merged commit ffac643 into master Jan 8, 2026
1 check failed
@multiplex55 multiplex55 deleted the codex/add-swap-and-remove-button-options branch January 9, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant