Add dashboard swap/remove toggles and removal confirmation#661
Merged
multiplex55 merged 1 commit intomasterfrom Jan 8, 2026
Merged
Add dashboard swap/remove toggles and removal confirmation#661multiplex55 merged 1 commit intomasterfrom
multiplex55 merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Swapbutton and theSwap with selectedbutton).Description
show_swap_buttonsandshow_remove_buttonsand aconfirm_remove_slot: Option<usize>toDashboardEditorDialogwith sensible defaults inDefault::default.Show swap(bound toshow_swap_buttons) andShow remove(bound toshow_remove_buttons).Removebutton is only shown whenshow_remove_buttonsis true and both theSwapandSwap with selectedcontrols are only shown whenshow_swap_buttonsis true.egui::Windowthat displaysRemove slot '{label}'?(usingSelf::slot_label(...)) and only marks a slot for removal when the user confirms; actual removal is gated by the confirmation state (confirm_remove_slot/confirm_remove).Testing
Codex Task