Skip to content

feat: add keep-open option to shell commands #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
multiplex55 merged 1 commit into from
Aug 27, 2025
Merged

feat: add keep-open option to shell commands #612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/gui/shell_cmd_dialog.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ pub struct ShellCmdDialog {
edit_idx: Option<usize>,
name: String,
args: String,
keep_open: bool,
}

impl ShellCmdDialog {
Expand All @@ -18,6 +19,7 @@ impl ShellCmdDialog {
self.edit_idx = None;
self.name.clear();
self.args.clear();
self.keep_open = false;
}

fn save(&mut self, app: &mut LauncherApp) {
Expand Down Expand Up @@ -54,6 +56,7 @@ impl ShellCmdDialog {
ui.input_mut(|i| i.consume_key(modifiers, egui::Key::Enter));
}
});
ui.checkbox(&mut self.keep_open, "Keep command prompt open after run");
ui.horizontal(|ui| {
if ui.button("Save").clicked() {
if self.name.trim().is_empty() || self.args.trim().is_empty() {
Expand All @@ -64,15 +67,17 @@ impl ShellCmdDialog {
name: self.name.clone(),
args: self.args.clone(),
autocomplete: true,
keep_open: false,
keep_open: self.keep_open,
});
} else if let Some(e) = self.entries.get_mut(idx) {
e.name = self.name.clone();
e.args = self.args.clone();
e.keep_open = self.keep_open;
}
self.edit_idx = None;
self.name.clear();
self.args.clear();
self.keep_open = false;
save_now = true;
}
}
Expand All @@ -95,6 +100,7 @@ impl ShellCmdDialog {
self.edit_idx = Some(idx);
self.name = name.clone();
self.args = args.clone();
self.keep_open = self.entries[idx].keep_open;
}
if ui.button("Remove").clicked() {
remove = Some(idx);
Expand All @@ -110,6 +116,7 @@ impl ShellCmdDialog {
self.edit_idx = Some(self.entries.len());
self.name.clear();
self.args.clear();
self.keep_open = false;
}
if ui.button("Close").clicked() {
close = true;
Expand Down Expand Up @@ -199,4 +206,15 @@ mod tests {
});
assert_eq!(args, "echo hi\n");
}

#[test]
fn open_resets_keep_open() {
let ctx = egui::Context::default();
let mut dlg = ShellCmdDialog {
keep_open: true,
..Default::default()
};
dlg.open();
assert!(!dlg.keep_open);
}
}
Loading