fix(workspace-jj): pin workspaces to parent rev + capture workspace names#40
Merged
fix(workspace-jj): pin workspaces to parent rev + capture workspace names#40
Conversation
…ames for cleanup - Pin each workspace to @- at creation time (--revision flag) so concurrent subagents create independent changes instead of chaining - Subagents now report workspace directory name (basename $PWD) alongside change ID, enabling accurate cleanup by the orchestrator - Fixes chaining issue observed in first fan-flames test run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues discovered during the first fan-flames test run:
--revision, concurrent jj workspaces see each other's changes and chain instead of branching independently. Now pins each workspace to@-(parent of working copy) at creation time, ensuring the fan-out pattern fan-flames expects.workspace-agent-a4eeb8f4), not predictable task names. Subagents now report their workspace directory name (basename $PWD) alongside their change ID, enabling accurate cleanup by the orchestrator.Test plan
jj logshows 3 independent changes off the same parent after fan-out🤖 Generated with Claude Code