bugfix: silent dataloss in udp socket send_to_many call (sendmmsg).#71
Open
lvboudre wants to merge 2 commits intomullvad:mainfrom
Open
bugfix: silent dataloss in udp socket send_to_many call (sendmmsg).#71lvboudre wants to merge 2 commits intomullvad:mainfrom
lvboudre wants to merge 2 commits intomullvad:mainfrom
Conversation
Removed Linux-specific tests for UdpSocket functionality.
Author
|
I deleted unit test that I have written, for some reason they don't work on your runner :/ . |
Member
|
Nice find! Looks good to me. We're discussing licenses right now, which prevents us from accepting outside contributions, but we'll get back to you asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation of send_many_to calls packets.clear() regardless of the return value of the sendmmsg syscall. On Linux, sendmmsg is not atomic; it iterates through the provided headers and may return early if the socket's send buffer (SO_SNDBUF) becomes full or if the kernel encounters backpressure.
When this happens, sendmmsg returns the number of messages successfully queued (which may be less than the total requested). By calling .clear(), we were silently dropping any packets that the kernel had not yet accepted.
Solution
this PR makes sure we loop over all remaining packet until they are all succesfully sent to the kernel.
This change is