Moved all deps to workspace.dependencies#70
Open
lvboudre wants to merge 1 commit intomullvad:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposed to unified all dependencies using
[workspace.dependencies]instead.This prevent
gotatunandgotatun-clito have divergent dependencies version that could cause developement issue in the future sincegotatun-clidepends ongotatun.Lastly, if we need to upgrade a dependencies major version, it forces us to make the entire codebase up to date, not just individual crates.
Using workspace dependencies prevent maintenance mistake overall, while allowing individual crates to pick and choose what they need.
This change is