Conversation
Notes
|
|
Hi @reneleonhardt, thanks for wanting to contribute! We are a bit reluctant to accept PRs before having a more refined review process and better CI set up. This will unfortunately have to wait until holidays have passed. Just a tip for future contributions: Please split your changes in as atomic commits as possible. That way we can accept some changes more easily, instead of having to reject the entire PR because of minor things. As an example in this case, we could likely accept the dependency bumps outright, but the dependabot CI will require some discussion. |
|
No stress from my side, enjoy your holidays 😄 I could split the commit and force-push them if it's important. But it's hard to explain from my point of view to wait months and years for contributions instead of just merging dependabot PRs whenever you're ready, it doesn't get much easier. |
Yeah, this is what I mean with "having a more refined review process". We have to make it obvious and easy for a third-party to contribute, but we have not gotten around to that yet. Soon.. 😄 I appreciate that you took the time to open and comment on this PR. Unfortunately, I think we'll have to discuss internally before I can go ahead with this PR. Happy holidays! 🌟 |
|
IMO dependabot makes no sense on Rust crates. We do not have it on any other repository. |
Chores
This change is