Open
Conversation
1cb23cc to
3b38433
Compare
Serock3
approved these changes
Nov 17, 2025
Contributor
Serock3
left a comment
There was a problem hiding this comment.
@Serock3 reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @hulthe)
hulthe
reviewed
Nov 17, 2025
Contributor
hulthe
left a comment
There was a problem hiding this comment.
We should test whether this allocator also fragments before adding it imo. We wouldn't want to encourage something that doesn't perform well.
@hulthe reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @MarkusPettersson98)
5470a02 to
253ac58
Compare
253ac58 to
9d50942
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds mi-malloc as an alternative memory allocator to libc. This is exposed via the new
mimallocfeature flag in thegotatun-clicrate.I've not played around too much with it yet, but adding the initial infrastructure for experimenting with different memory allocators proved to be rather straightforward.
This change is