Skip to content

Rollback all unsucessful transactions during shutdown #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ca-stefan-cordes wants to merge 2 commits into
base: support/2.1.x
Choose a base branch
from
Open

Rollback all unsucessful transactions during shutdown #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70d71b5
Rollback all inflight transactions when shutting down
ca-stefan-cordes Feb 16, 2022
b8afabe
restore whitespaces for comparing
ca-stefan-cordes Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions btm/src/main/java/bitronix/tm/BitronixTransactionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,12 +370,37 @@ private void internalShutdown() {
if (txCount > 0) {
if (log.isDebugEnabled()) log.debug("still " + txCount + " in-flight transactions, shutting down anyway");
dumpTransactionContexts();
rollbackAllInFlightTransactions();
}
else {
if (log.isDebugEnabled()) log.debug("all transactions finished, resuming shutdown");
}
}

/**
* Rollback all inflight transactions when shutting down to inform all resource holders (specially XA ones)
* nothing more will happen here.
* This avoids indoubt threads like
* <pre>
* V466-THREAD HAS BEEN INDOUBT FOR 27:25:58
* V451-RESYNC WITH COORDINATOR STILL PENDING
* </pre>
*/
private void rollbackAllInFlightTransactions() {
log.warn("Rollback all remaining "+inFlightTransactions.size()+" inFlightTransactions");
for (Map.Entry<Uid, BitronixTransaction> entry : inFlightTransactions.entrySet()) {
BitronixTransaction tx = entry.getValue();
try {
log.warn("Rollback Uid="+entry.getKey()+" inFlightTransaction="+tx.toString());
tx.rollback();
} catch (SystemException e) {
log.warn("Ignore Exception when rolling back during shutdown Uid="+entry.getKey()+" inFlightTransaction="+tx.toString());
}
}
log.info("Rollback of remaining inFlightTransactions finished.");
inFlightTransactions.clear();
}

public String toString() {
return "a BitronixTransactionManager with " + inFlightTransactions.size() + " in-flight transaction(s)";
}
Expand Down