Use xaresource tmsuspend when suspending instead of tmsuccess

[ca-stefan-cordes]

The XAResourceHolderState.suspend did not call .end(XAResource.TMSUSPEND);
but .end(XAResource.TMSUCCESS); and so a compicated re-join needed to be implemented on .resume()

Just calling
.end(XAResource.TMSUSPEND);
on suspend and
.start(XAResource.TMRESUME);
on resume ensures all resources keeping same and XA provider is not wondering why TMSUSPEND is never called:

IBM asked me:

Would we be right in our understanding that in this context, the application is enlisting MQ in a XA transaction, doing a piece of MQ work (eg. getting a message from a queue), then suspending the transaction, eg:
XAResource.end( Xid xid, int flags )
passing the TMSUSPEND flag as the flags argument, then doing the new piece of transacted work with the database, before attempting to resume the transaction with:
XAResource.start( Xid xid, int flags )
passing the TMRESUME flag to the queue manager?

and I need to answer: "Well .... you know .... looks like .... hmmm..."

P.S.: Probably not all tests green now as mvn clean test alreads showed errors locally on my environment.

[ca-stefan-cordes]

The request to use suspend/resume directly was already made on the original repository with scalar-labs#40
@lorban already stated 2015 that

Looking back, it probably was a mistake as almost no resource implements transaction interleaving and this simpler model fits the bill for the more common transaction-per-connection model.

and so today is a good day to switch the default to the lightweight suspend/resume.

In case you want to be able to keep old behavior via

I can cherry pick the (open) commit
TransactionManagerServices.getConfiguration().isQuickSuspend()
from
scalar-labs@ce7ed4b
here, too.