This repository was archived by the owner on Jul 1, 2024. It is now read-only.
Remove unnecessary send to b.propchanged#184
Open
amrbekhit wants to merge 1 commit intomuka:masterfrom
Open
Conversation
Sending `nil` to `b.propchanged` when the context is done does not seem to serve any purpose. The `bluez.WatchProperties` function that creates `propchanged` does not read from it. The channel is also not accessible outside of the beacon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending
niltob.propchangedwhen the context is done does not seem to serve any purpose. Thebluez.WatchPropertiesfunction that createspropchangeddoes not read from it. The channel is also not accessible outside of the beacon.