-
-
Notifications
You must be signed in to change notification settings - Fork 295
Bump MUI infra packages #3371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Bump MUI infra packages #3371
Conversation
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
503ec2f to
480169c
Compare
480169c to
e4eb650
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
LukasTy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👌
@Janpot I refreshed the PR.
Is there anything missing to finalize this? 🤔
| globalThis.BASE_UI_ANIMATIONS_DISABLED = true; | ||
| return; | ||
| // Wait for all tooltips to be unmounted | ||
| // TODO: really necessary? Feels like a bug in the test setup/teardown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might have been an effort to avoid flaky tests (possible race conditions).
If tests do not become more flaky after this change, I'd consider this a success.
cc @michaldudak for context. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this was an attempt to make the tests more reliable as there's quite a lot of async code in the Tooltip. If removing this wait doesn't make things worse, I'm happy.
Yes, mui/mui-public#927 needs to be merged |
This PR contains the following updates:
^2.0.15->^2.0.169cc15ae->2f944b9Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.