Let Unicode work, add Travis and Coveralls coverage #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Params are already urlencoded by this point. Quoting here can mess up unicode URLs. The included test relies on two environment variables to be set: AWS_ACCESS_ID and AWS_SECRET_ACCESS_KEY. The associated credentials should be authorized to do Alexa API queries.
And add test runner to setup.py. The setup.cfg aliases test to pytest.
For TravisCI and coveralls.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #11. I've added a test and also stuck in TravisCI and Coveralls coverage.