Skip to content

Conversation

@mudler
Copy link
Owner

@mudler mudler commented Dec 19, 2025

No description provided.

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Copilot AI review requested due to automatic review settings December 19, 2025 22:01
@mudler mudler merged commit 9a33537 into main Dec 19, 2025
6 checks passed
@mudler mudler deleted the consume/xlog branch December 19, 2025 22:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the logging package from an internal module (github.com/mudler/LocalAGI/pkg/xlog) to an external shared repository (github.com/mudler/xlog v0.0.1). This enables the logging functionality to be reused across multiple repositories.

Key Changes

  • Updated all import statements across 35+ files to reference the external xlog package
  • Removed the internal xlog package implementation (pkg/xlog/xlog.go)
  • Added external xlog dependency (v0.0.1) to go.mod and go.sum

Reviewed changes

Copilot reviewed 37 out of 38 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
go.mod Added xlog v0.0.1 as a dependency (marked indirect)
go.sum Added checksums for xlog v0.0.1 package
pkg/xlog/xlog.go Deleted internal logging package implementation
webui/types/openai.go Updated xlog import path
webui/routes.go Updated xlog import path
webui/app.go Updated xlog import path
tests/e2e/e2e_test.go Updated xlog import path
services/prompts/custom.go Updated xlog import path
services/prompts.go Updated xlog import path
services/filters.go Updated xlog import path
services/connectors/*.go Updated xlog import path in all connector files (twitter, telegram, slack, matrix, irc, githubpr, githubissue, email, discord)
services/connectors.go Updated xlog import path
services/common.go Updated xlog import path
services/actions/*.go Updated xlog import path in GitHub-related action files
services/actions.go Updated xlog import path
pkg/localrag/client.go Updated xlog import path
pkg/llm/json.go Updated xlog import path
core/types/observable.go Updated xlog import path and fixed field alignment formatting
core/state/pool.go Updated xlog import path
core/conversations/conversationstracker.go Updated xlog import path
core/agent/*.go Updated xlog import path in agent-related files (observer, mcp, knowledgebase, agent_test, agent, actions)
core/action/custom.go Updated xlog import path

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github.com/huandu/xstrings v1.5.0 // indirect
github.com/mitchellh/copystructure v1.2.0 // indirect
github.com/mitchellh/reflectwalk v1.0.2 // indirect
github.com/mudler/xlog v0.0.1 // indirect
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The xlog package should not be marked as indirect since it's directly imported and used throughout the codebase. It should be moved to the direct dependencies section (lines 5-31) without the "// indirect" comment.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants